[FFmpeg-devel] [PATCH] Improved analysis of h264 bitstreams with no B frames

[Michael Niedermayer]

On Sun, May 08, 2011 at 07:53:54AM -0400, Mike Scheutzow wrote:
> Michael Niedermayer wrote:
>> On Sat, May 07, 2011 at 12:03:48PM -0400, Mike Scheutzow wrote:
>>   
>>> The sps.constraint_set0_flag indicates that the bitstream is baseline profile,
>>> which means the stream has no B-pictures.  This patch fixes trac0088.
>>>     
>>
>> sps.constraint_set_flags&1 indicates no B frames
>> but no B frames does not implicate low_delay=1.
>>   
> It seems to me that's exactly what the other code in FFmpeg assumes.
>
> FFmpeg currently uses low_delay=0 to set has_b_frames=1 which then  
> rejects PTS==DTS for I and P pictures.
>
> Which assumption do you prefer to change?

the variable "has_b_frames" is misnamed, it shouldnt be named like that
its semantically == h->sps.num_reorder_frames


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110508/61c3bf46/attachment.asc>