[FFmpeg-devel] [PATCH] lavfi: add avfilter_copy_frame_props()

[Stefano Sabatini]

On date Friday 2011-05-06 11:37:52 +0200, Stefano Sabatini encoded:
> On date Thursday 2011-05-05 18:50:12 +0200, Michael Niedermayer encoded:
> > On Thu, May 05, 2011 at 02:46:59PM +0200, Stefano Sabatini wrote:
> [...]
> > > It the user wants to use libavfilter without libavcodec, she
> > > configures FFmpeg with --disable-libavcodec and compiles, libavfilter
> > > is compiled but the libavfilter/avcodec.o module is not compiled in
> > > (and thus avfilter_copy_frame_props won't be available at run-time).
> > > 
> > > In the application she won't need AVFrame, *and* she won't include
> > > libavfilter/avcodec.h, so no need to have libavcodec/avcodec.h
> > > installed.
> > > 
> > > If she wants libavfilter+libavcodec, she will configure/compile FFmpeg
> > > with --enable-avcodec, and will include libavcodec/avcodec.h. Since
> > > she's already using libavcodec in her application, avoiding
> > > libavcodec/avcodec.h inclusion in libavfilter/avcodec.h is pointless.
> > > 
> > > In case she may need libavfilter/libavcodec conditionally, she can
> > > implement the inclusion logic in the application:
> > > #if CONFIG_AVCODEC
> > > #include "libavfilter/avcodec.h"
> > > #endif
> > > 
> > > and do the same in the code.
> > > 
> > > Of course in order to avoid missing symbols problems, libavfilter
> > > compiled for a distro should always enable libavcodec, but this is
> > > definitively not required for custom projects.
> > > -- 
> > > FFmpeg = Frightening & Fierce Mean Power Experimenting Generator
> > 
> > >  ffmpeg.c                  |    1 +
> > >  ffplay.c                  |    5 +++--
> > >  libavfilter/Makefile      |    5 ++++-
> > >  libavfilter/avcodec.c     |   42 ++++++++++++++++++++++++++++++++++++++++++
> > >  libavfilter/avcodec.h     |   40 ++++++++++++++++++++++++++++++++++++++++
> > >  libavfilter/vsrc_buffer.c |    9 +++------
> > >  libavfilter/vsrc_movie.c  |    8 ++------
> > >  7 files changed, 95 insertions(+), 15 deletions(-)
> > > a80ea37da944fa90ad326fc83f352287725fc095  0004-lavfi-add-avfilter_copy_frame_props.patch
> > > From de988680f06be04b8bc0707066c63a29a061f8dd Mon Sep 17 00:00:00 2001
> > > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > > Date: Sun, 1 May 2011 14:47:05 +0200
> > > Subject: [PATCH] lavfi: add avfilter_copy_frame_props()
> > 
> > If you prefer this solution, then its ok with me
> 
> Well I'll apply it soon, please people comment if you want to say
> something about it.

Done.
-- 
FFmpeg = Frightening Fanciful Maxi Pacific Educated Game