[FFmpeg-devel] [PATCH] lavfi: add avfilter_copy_frame_props()

[Michael Niedermayer]

On Thu, May 05, 2011 at 01:08:55AM +0200, Stefano Sabatini wrote:
> On date Tuesday 2011-05-03 01:49:19 +0200, Michael Niedermayer encoded:
> > On Tue, May 03, 2011 at 12:20:48AM +0200, Stefano Sabatini wrote:
> > > On date Tuesday 2011-05-03 00:06:11 +0200, Michael Niedermayer encoded:
> > > > On Mon, May 02, 2011 at 07:26:13PM +0200, Stefano Sabatini wrote:
> > > > > On date Monday 2011-05-02 12:42:04 +0200, Michael Niedermayer encoded:
> > > > > > On Sun, May 01, 2011 at 04:29:54PM +0200, Stefano Sabatini wrote:
> > > > > [...] 
> > > > > > >  ffmpeg.c                  |    1 
> > > > > > >  ffplay.c                  |    5 ++--
> > > > > > >  libavfilter/Makefile      |    2 -
> > > > > > >  libavfilter/avcodec.h     |   50 ++++++++++++++++++++++++++++++++++++++++++++++
> > > > > > 
> > > > > > isnt it possible to just always install libavcodec/avcodec.h even
> > > > > > if libavcodec is disabled?
> > > > > 
> > > > > I would prefer to avoid hacking configure and keep the dependency on
> > > > > libavcodec strict, AVFrame should be used only if libavcodec is used,
> > > > > so I'd prefer not to make distinctions between compile-time and
> > > > > running-time dependencies (and we could need at some point the use of
> > > > > some function from libavcodec).
> > > > 
> > > 
> > > > is this change needed at all? #include "libavcodec/avcodec.h" in
> > > > libavfilter should use the non installed header and no installed
> > > > header from libavfilter shouldneed  libavcodec/avcodec.h for a struct
> > > > pointer
> > > > am i missing something ?
> > > 
> > > Do you mean something like this:
> > > 
> > > struct AVFrame;
> > > 
> > > static inline
> > > void avfilter_copy_frame_props(AVFilterBufferRef *dst, const AVFrame *src);
> > 
> > i was thinking of
> > void avfilter_copy_frame_props(AVFilterBufferRef *dst, const struct AVFrame *src);
> 
> Sorry I can't see the point of avoiding #include
> "libavcodec/avcodec.h" when the file is supposed to be used only when
> avcodec.h is used in the application, in other words you can avoid
> including libavcodec/avcodec.h, but the application will *have* to do
> it anyway, and even if you don't include it I can't see the advantage.

the advantage is that we dont have a interdependancy in the headers
a user application can use libavfilter on a system without libavcodec
just not easily avfilter_copy_frame_props()
If the system has both installed a user app can use all.

including the libavcodec header from libavfilter/avcodec.h will
require libavcodec/avcodec.h to be installed when libavfilter is
installed so you either have libavfilter depend on libavcodec or
have to install libavcodec/avcodec.h even when libavcodec is not.

but maybe i miss an option.



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110505/0be04f45/attachment.asc>