[FFmpeg-devel] [PATCH] encoder for adobe's flash ScreenVideo2 codec

[Michael Niedermayer]

On Fri, Apr 29, 2011 at 08:03:01PM -0700, Daniel Verkamp wrote:
> On Thu, Apr 28, 2011 at 5:30 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Wed, Jul 22, 2009 at 11:10:45AM -0600, Joshua Warner wrote:
> >> Him
> >>
> >> I fixed the issues you guys have commented on (tell me if I
> >> accidentally missed one), and the revised patch is attached.
> >
> > Applied locally will push to main ffmpeg git
> > it makes no sense to let this rot in the ML archives just because its
> > not perfect
> >
> 
> Thanks for merging this!
> 
> However, a quick test encoding this sample shows a problem:
>   http://drv.nu/temp/flashsv2/screen.flv

iam not sure how to test the resulting file ...
what do you use to play it ?


> 
> Around 2-4 seconds into the video, some blocks are corrupted.
> 
> Reverting 4517ba092e0606e9473c8e148c9895b01f975e18 ("flashsv2enc:fix
> segfault") fixes the problem for this sample.  I could not reproduce
> the mentioned segfault.  I don't understand how that code is supposed
> to work, but it looks like moving the FFSWAP past the use of
> s->keybuffer - s->encbuffer will definitely change the results.


without 4517ba092e0606e9473c8e148c9895b01f975e18

s->key_blocks[i].enc += (s->keybuffer - s->encbuffer);
will add the pointer difference the wrong way and instead of
switching buffers point to random memory.
Id guess the most likely way this can work better is by never using
the previous data and encoding as keyframe.

you can try running the code under valgrind if it doesnt segfault
for you.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110504/0ed70d9c/attachment.asc>