[FFmpeg-devel] [PATCH] DVB Subtitles Fix

[JULIAN GARDNER]

----- Original Message -----
From: JULIAN GARDNER <joolzg at btinternet.com>
To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
Cc: 
Sent: Wednesday, 27 April 2011, 7:12
Subject: Re: [FFmpeg-devel] [PATCH] DVB Subtitles Fix



--- On Wed, 27/4/11, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> From: Carl Eugen Hoyos <cehoyos at ag.or.at>
> Subject: Re: [FFmpeg-devel] [PATCH] DVB Subtitles Fix
> To: ffmpeg-devel at ffmpeg.org
> Date: Wednesday, 27 April, 2011, 1:08
> JULIAN GARDNER <joolzg <at>
> btinternet.com> writes:
> 
> [...]
> 
> > -             
>                
>       h->rects[object_id]->h >>
> 1);
> > +             
>                
>          
> h->rects[object_id]->h >> 1);
> 
> This looks unrelated / unintended.
> 
> [...]
> 
> > -        if (depth & 0x80)
> > -           
> clut->clut4[entry_id] = RGBA(r,g,b,255 - alpha);
> 
> > +            if (depth
> & 0x80)
> > +             
>   clut->clut4[entry_id] = RGBA(r,g,b,255 - alpha);
> 
> Please make your patch smaller (and easier to review) by
> not re-indenting these
> lines.
> 
> Feel free to wait for a real review, Carl Eugen
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

Just a question regarding the patch i sent, do i have to repost it or is it in the pipeline to be added?

I have another patch which changes the udp.c so it uses a thread for the receiving of the data into a circular buffer, been in my ffmpeg build since december so i know it works ok. i have modified it to build with a git pull from the weekend.

Should i wait with this patch or post it

joolz