[FFmpeg-devel] [PATCH]8 and 24 bit True Audio

[Michael Niedermayer]

On Mon, May 02, 2011 at 11:12:56PM +0000, Carl Eugen Hoyos wrote:
> Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
> 
> > +            case 3: avctx->bits_per_coded_sample = 24;
> 
> > +            case 3: {
> > +                int32_t *samples = data;
> > +                for (p = s->decode_buffer; p < s->decode_buffer + (framelen *
> s->channels); p++)
> > +                    *samples++ = AV_RN32(p) << 8;
> 
> Does this need a small change so the 8 MSB are repeated as LSB?

strictly speaking yes, it wont make a practical difference though

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110503/86fb92e4/attachment.asc>