[FFmpeg-devel] [PATCH] Fix buffer over-read in XSUB decoder

[Reimar Döffinger]

On Mon, May 02, 2011 at 12:35:58PM +0200, Michael Niedermayer wrote:
> On Mon, May 02, 2011 at 09:19:05AM +0200, Alexandre Colucci wrote:
> > 
> > On 27 avr. 2011, at 22:28, Michael Niedermayer wrote:
> > 
> > > On Tue, Apr 26, 2011 at 10:58:57AM +0200, Alexandre Colucci wrote:
> > >> Hi,
> > >> 
> > >> The attached patch fixes a buffer over-read when decoding XSUB subtitles. The rlelen represents the length of the first field only and not the whole buffer. See also xsubenc.c.
> > >> 
> > >> Alexandre
> > >> 
> > > 
> > >> xsubdec.c |    2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >> addec7c3f15f9b9e7ab1776df6e6d18eb10bb7ba  submission.diff
> > >> diff --git a/libavcodec/xsubdec.c b/libavcodec/xsubdec.c
> > > 
> > > LGTM, iam not maintainer though
> > > 
> > > [...]
> > > 
> > 
> > Any news on this patch?
> 
> ill apply in a few days unless reimar objects

No, it's fine. But I have removed the now unused rlelen
and added a comment explaining what we are doing and why.
I'll push after testing.