[FFmpeg-devel] [PATCH] ALSA: fix a stupid bad use of av_freep

[Michael Niedermayer]

On Thu, Mar 31, 2011 at 06:53:22PM +0200, Nicolas George wrote:
> Hi. The attached patch fixes a stupid bad use of av_freep. I did not spot it
> because the prototype of av_freep is stupid (but AFAIK the C standard does
> not allow better) and the test files I used ended with a little bit of
> silence.
> 
> Thanks to Carl Eugen for spotting it.
> 
> Regards,
> 
> -- 
>   Nicolas George

>  alsa-audio-common.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 04053da69fceab82bc308b1b7d9678f0b6497aff  0001-ALSA-fix-a-stupid-bad-use-of-av_freep.patch
> From 1e96d4c71e68fdefc284d7dfb9701d1378a024c8 Mon Sep 17 00:00:00 2001
> From: Nicolas George <nicolas.george at normalesup.org>
> Date: Thu, 31 Mar 2011 18:49:07 +0200
> Subject: [PATCH] ALSA: fix a stupid bad use of av_freep.
> 
> It caused a segfault when channel reordering was in use and the last chunk
> of data was not silent.
> Spotted and diagnosed by Carl Eugen Hoyos.
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  libavdevice/alsa-audio-common.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110331/746fc706/attachment.asc>