[FFmpeg-devel] [PATCH 4/4] Add MxPEG decoder

[Michael Niedermayer]

On Thu, Mar 31, 2011 at 04:55:04PM +0400, Anatoly Nenashev wrote:
> On 31.03.2011 04:41, Michael Niedermayer wrote:
>> On Mon, Mar 28, 2011 at 12:03:58AM +0400, Anatoly Nenashev wrote:
[...]
>>> +
>>> +typedef struct MXpegDecodeContext {
>>> +    MJpegDecodeContext jpg;
>>> +    AVFrame picture[2]; /* pictures array */
>>> +    int picture_index; /* index of current picture */
>>> +    int got_sof_data; /* true if SOF data successfully parsed */
>>> +    int got_mxm_bitmask; /* true if MXM bitmask available */
>>> +    uint8_t *mxm_bitmask; /* bitmask buffer */
>>> +    unsigned bitmask_size; /* size of bitmask */
>>> +    int has_complete_frame; /* true if has complete frame */
>>> +    uint8_t *completion_bitmask; /* completion bitmask of macroblocks */
>>> +    unsigned mb_width, mb_height; /* size of picture in MB's from MXM header */
>>> +} MXpegDecodeContext;
>>>      
>> The comments should be made doxygen compatible (///<  ...)
>>    for example see:
>> http://ffmpeg.org/doxygen/trunk/
>> for our daily generated doxygen docs from trunk (there are of course
>> also ones for the releases)
>>    
>
> Ok. I'll correct these comments.
>
>> ill try to review the rest of this patch in the next days
>> i sadly dont have the time ATM
>>
>>    
>
> Ok, thank you. I will make these and other changes but MxPEG patch is  
> just pushed to Libav so I don't want to support two versions of patch.
> Do you know any solution for this situation?

yes, each part of ffmpeg has a person who knows it well, and does
proper technical reviews. (well ideally that is, in reality there
are parts where theres noone and very few where there are multiple)

This person is called a maintainer by us (and also for example
the kernel). (In libav, maintainer seems to be more a political position
than a technical one.)

Well that (technical) maintainer should review and approve patches for
the area of his maintainership/knowledge.
Bypassing the most knowledgeable person is generally a bad idea but
if he is busy for weeks its surely justified to find someone else
to do review and commit.

How does that awnser the ffmpeg vs. libav question?
Well it doesnt and IMHO it doesnt have to. when you have a patch for
ac3 look in MAINTAINERS, it lists Justin Ruggles
he is subscribed to both libav-devel and ffmpeg-devel so you can send
ac3 patches to either list and get a review by the most qualified
person.
how about mjpeg? i know that best, so i should do the review.
(and the just found security issue shows why)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110331/b5e0b724/attachment.asc>