[FFmpeg-devel] [PATCH 1/4] Support reference picture defined by bitmask in MJPEG's SOS decoder

[Michael Niedermayer]

On Mon, Mar 28, 2011 at 12:01:40AM +0400, Anatoly Nenashev wrote:
>
[...]

>      }
>  
> -    if(s->interlaced && s->bottom_field)
> -        data += linesize >> 1;
> +    if(s->interlaced && s->bottom_field) {
> +        int offset = linesize >> 1;
> +        data += offset;
> +        reference_data += offset;
> +    }

This doesnt fit together with:
> +                if (jpg->interlaced) {
> +                    av_log(avctx, AV_LOG_ERROR, "Interlaced mode not supported in MxPEG\n");
> +                    return AVERROR(EINVAL);
> +                }

do interlaced mxpeg exist / is it allowed?
if so it should be supported, if not theres no need to partially
implement it

Not a major issue but it seems inconsistent

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110331/2b8e61c7/attachment.asc>