[FFmpeg-devel] mt fork merged but currently disabled?

[Michael Niedermayer]

On Sat, Mar 26, 2011 at 01:35:32PM +0100, Reimar Döffinger wrote:
> On Sat, Mar 26, 2011 at 12:32:57PM +0100, Michael Niedermayer wrote:
> > On Sat, Mar 26, 2011 at 05:31:10AM +0100, Gianluigi Tiesi wrote:
> > > Hi,
> > > 
> > > by looking at libavcodec/pthreads.c
> > > 
> > > in ff_thread_init
> > > 
> > > I suspect something like:
> > > 
> > > avctx->thread_count = thread_count;
> > > 
> > > is missing, while instead is there in w32thread.c
> > > 
> > > I've tried to add the line, and finally I get two decoding
> > > threads when calling mplayer with lavdopts=threads=2
> > > option
> > 
> > no, see commits below:
> 
> This seems completely broken to me.
> First, it seems to be an API change, that shouldn't just be done
> in the middle without an major bump.

i know
tell that to who commited that in the first place.


> Next, it seems like an inconsistent mess now.
> The ff_thread_init without threads and w32 threads now sets
> that one but the pthreads one does not.

yes


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110326/98c13960/attachment.asc>