[FFmpeg-devel] [PATCH] ac3dec: avoid pointless alloc and indirection for input_buffer

[Reimar Döffinger]

On Fri, Mar 25, 2011 at 01:25:58AM +0100, Michael Niedermayer wrote:
> On Thu, Mar 24, 2011 at 09:29:27PM +0100, Reimar Döffinger wrote:
> > Since we now always allocate it,
> 
> Note, i do not consider this a good idea, we have things like a fast
> flag based upon which the copy could be skiped

I think we'd really need a new flag, I don't think it's acceptable
to use that fast flag for stuff that might cause crashes.

> > it can simply be made part of the context
> > instead.
> 
> missing alignment otherwise LGTM

I don't want to insist really.
I'm going to send an updated patch, but I'd rather leave it to the
maintainer to decide.