[FFmpeg-devel] [PATCH] Fix incorrect colors when decoding DVD subtitles

Joakim Plate elupus at ecce.se
Fri Mar 25 16:47:25 CET 2011


Michael Niedermayer <michaelni <at> gmx.at> writes:

> 
> On Fri, Mar 25, 2011 at 11:25:02AM +0100, Alexandre Colucci wrote:
> > Hi,
> > 
> > On DVD and HD-DVD colors are stored in the order YCrCb (and not YCbCr) as 
mentioned in the specifications:
> > see DVD Specifications for Read-Only Disc / Part 3, 4.3 Program Chain 
Information (7) PGC_SP_PLT
> > see DVD Specifications for High Definition Disc, 5.2 Navigation for Standard 
Content (11) PGC_SDSP_PLT
> > see DVD Specifications for High Definition Disc, 5.2 Navigation for Standard 
Content (12) PGC_HDSP_PLT
> > see DVD Specifications for High Definition Disc, 5.5 Presentation Data (4) 
SET_COLOR2
> > 
> > When decoding a DVD or HD-DVD subtitle, the colors were incorrectly set.
> > 
> > Alexandre
> > 
> > 
> 
> >  dvdsubdec.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 87de9dd6863eaf80ea6af4fe90bd370cfd76c2c1  submission.diff
> 
> applied, thank you
> 
> [...]
> 

While i agree the change is valid. This breaks apps that worked around that 
issue. Think we could get a micro version bump for it?







More information about the ffmpeg-devel mailing list