[FFmpeg-devel] [GSoC] Qualification Task

[Stefano Sabatini]

On date Thursday 2011-03-24 10:59:16 +0200, Mina Nagy Zaki encoded:
> On Wednesday 23 March 2011 18:13:23 Michael Niedermayer wrote:
> > On Wed, Mar 23, 2011 at 05:44:48AM +0200, Mina Nagy Zaki wrote:
[...]
> > > The solution I see best is IMHO simply doing one sox effect per lavfi sox
> > > wrapper instance as I mentioned earlier, and as Peter later added. We
> > > simply create and initialize one effect and flow samples through it as
> > > they arrive. This way we can bypass a lot of the problems, and we don't
> > > have to write code to handle sox chains, but instead let the lavfi code
> > > do its thing.
> > 
> > i agree that 1 wraper instance should only contain 1 filter instance
>
> I have a working sox wrapper, but let me paste my commit message:
> 
> commit 9022e7cdb686c7397d82b00ee9c8e70ed7ddeef4
> Author: Mina Nagy Zaki <mnzaki at gmail.com>
> Date:   Thu Mar 24 09:21:49 2011 +0200
> 
>     Added a sox wrapper filter.
>     
>     Loads and initializes a single sox filter and passes samples to it
>     during filter_samples.
>     
>     It is currently very limited due to several problems that need
>     to be figured out, including:

>     - Draining is not handled yet until I figure out finding EOF

Yes.

>     - Using config_props to set rate/fmt/etc from an output pad
>       does not propagate the changes

This should work (at least for format and rate), check how it is done
in aresample.

>     - No channel negotiation mechanism or means to choose between
>       planar or packed data

Yes.

>     - No way to tell the filter system that we were unable to consume
>       all the given input
>     - ...
> 
> I have tested with the sox earwax filter and it works fine. Testing with sox's 
> rate filter though messes up the file due to the 2nd point above, though I'm 
> unsure if it's only me doing something wrong.

Post the patch so that we can comment on / review it :).
-- 
FFmpeg = Faithful and Fascinating Multimedia Practical Eager Gorilla