[FFmpeg-devel] [PATCH 2/2] libswcale: PIX_FMT_BGR48LE and PIX_FMT_BGR48BE scaler implementation

Michael Niedermayer michaelni at gmx.at
Fri Mar 18 02:41:20 CET 2011


On Thu, Mar 17, 2011 at 08:38:22PM +0100, Reimar Döffinger wrote:
> On 17 Mar 2011, at 15:16, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Mar 17, 2011 at 09:20:30PM +1100, Peter Ross wrote:
> >> ---
> >> libswscale/swscale.c          |   49 +++++++++++++++++++++++++++++++++++++++++
> >> libswscale/swscale.h          |    2 +-
> >> libswscale/swscale_internal.h |   10 ++++++-
> >> libswscale/swscale_template.c |    7 ++++++
> >> libswscale/utils.c            |    2 +
> >> libswscale/yuv2rgb.c          |   12 ++++++++++
> >> 6 files changed, 79 insertions(+), 3 deletions(-)
> > 
> > LGTM if tested
> 
> Shouldn't it rather use one of the av_asserts instead of just assert?

yes, we should improve our patcheck script

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110318/85c35dc5/attachment-0001.asc>


More information about the ffmpeg-devel mailing list