[FFmpeg-devel] [PATCH 1/2] aacenc: refactor parts of the AAC psymodel

[Alex Converse]

On Tue, Mar 8, 2011 at 7:46 AM, Justin Ruggles <justin.ruggles at gmail.com> wrote:
> On 03/08/2011 05:32 AM, Nathan Caldwell wrote:
>
>> 3GPP:
>> Remove ffac from and move min_snr out of AacPsyBand.
>> Rearrange AacPsyCoeffs to make it easier to implement energy spreading.
>> Rename the band[] array to bands[]
>> Copy energies and thresholds at the end of analysis.
>>
>> LAME:
>> Use a loop instead of an if chain in LAME windowing.
>
>
> These changes should probably be split up. ?Smaller incremental changes
> make the patch more understandable and helps with tracking down bugs in
> the future. ?Especially since part of this patch seems to be cosmetic.
>

Agreed, I'd like to see the pure refactor portion split out, but I'm
willing to let it slide this time.

> But the individual changes look reasonable to me.
>

+1

Regards,
Alex