[FFmpeg-devel] [PATCH 1/1] CrystalHD decoder support v7

[Philip Langdale]

On Thu, 10 Mar 2011 20:48:43 +0100
Michael Niedermayer <michaelni at gmx.at> wrote:

> 
> > +
> > +/* Timeout parameter passed to DtsProcOutput() in us */
> > +#define OUTPUT_PROC_TIMEOUT 50
> > +/* Step between fake timestamps passed to hardware in units of
> > 100ns */ +#define TIMESTAMP_UNIT 100000
> > +/* Initial value in us of the wait in decode() */
> > +#define BASE_WAIT 10000
> > +/* Increment in us to adjust wait in decode() */
> > +#define WAIT_UNIT 1000
> 
> comments could be made doxygen compatible

Sure. I'll include it in the next patch series.

> 
> Its normally possible to simplify link list code by using a pointer
> to where the pointer is stored (aka &priv->head)
> 
> also an array might be simpler than a linked list.

I need to think more about this but I'm always looking to tidy it up.
I was reluctant to use an array because of the overhead of dealing
with removing entries out-of-order, which is going to happen fairly
often.

Thanks,

--phil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110313/f6fba75b/attachment.pgp>