[FFmpeg-devel] Patch review request: 10bit DNxHD decoding support

[Stefan Gehrer]

On 03/11/2011 10:11 AM, Joseph Artsimovich wrote:
>> @@ -39,8 +40,16 @@ typedef struct {
>>        int cur_field;                      ///<  current interlaced field
>>        VLC ac_vlc, dc_vlc, run_vlc;
>>        int last_dc[3];
>> -    DSPContext dsp;
>> +
>> +    /* It easier to have both DSPs always initialized than initialize one
>> +       on demand. Note that these DSPs may have different permutation
>> tables. */
>> +    DSPContext dsp8;
>> +    DSPContext dsp10;
>> +    DSPContext* dsp;
>>
>> I think you should avoid having DSPContext twice. If you really need 8bit and
>> 10bit decoding in the same file or stream, you could just add a second
>> permutation table within DSPContext, one for the 8bit IDCT as is and the
>> other for the 10bit IDCT.
> Any particular reason why not?  I mean they are reentrant and relatively lightweight.

Call me old-fashioned, but I would just not add 4k to a structure
without good reason. But maybe I am just too embedded-centric and
that's not really the target audience for 10bit DNxHD decoding.

Stefan