[FFmpeg-devel] compiling ffmpeg with cygwin

[Víctor Paesa]

Hi,

On Fri, Mar 11, 2011 at 18:41, Reimar D?ffinger wrote:
> On Thu, Mar 10, 2011 at 11:40:39PM +0100, V?ctor Paesa wrote:
>> diff --git a/libavcodec/aaccoder.c b/libavcodec/aaccoder.c
>> index 8063fb6..0b75ac0 100644
>> --- a/libavcodec/aaccoder.c
>> +++ b/libavcodec/aaccoder.c
>> @@ -30,6 +30,7 @@
>> ? * add sane pulse detection
>> ? ***********************************/
>>
>> +#include "libavutil/libm.h"
>> ?#include <float.h>
>> ?#include "avcodec.h"
>> ?#include "put_bits.h"
>> diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c
>> index 237d51a..334a6aa 100644
>> --- a/libavcodec/aacsbr.c
>> +++ b/libavcodec/aacsbr.c
>> @@ -32,6 +32,7 @@
>> ?#include "aacsbrdata.h"
>> ?#include "fft.h"
>> ?#include "aacps.h"
>> +#include "libavutil/libm.h"
>>
>> ?#include <stdint.h>
>> ?#include <float.h>
>
> The order of local vs. system headers is rather chaotic, if it's
> intentional it should be documented why.

Hmmm, I guess that issue has not been raised frequently, because chaos
seems the norm:

$ gawk '
(FNR==1) {print order; order=""}
/#.*include.*\"/ {
  if (!(order))
    order="local"
  else if (order=="system") {
     order="first local, then system"
     nextfile
  }
}
/#.*include.*\</ {
  if (!(order))
    order="system"
  else if (order=="local") {
     order="first system, then local"
     nextfile
  }
}
' libavcodec/*.c |sort|uniq -c
      4
    122 first local, then system
    319 first system, then local
      1 system

What's the preference?

Regards,
V?ctor