[FFmpeg-devel] Patch review request: 10bit DNxHD decoding support

[Michael Niedermayer]

On Fri, Mar 11, 2011 at 09:34:41AM +0000, Joseph Artsimovich wrote:
> > >      p8idct(block, temp, NULL,         0, 1, 8, 0);
> > >      p8idct(NULL , temp, dest, line_size, 8, 1, 3);  }
> > > +
> > > +void ff_faanidct10_put(uint16_t *dest, int line_size, DCTELEM block[64]){
> > > +    FLOAT temp[64];
> > > +    FLOAT* p_tmp = temp;
> > > +    int i, j;
> > > +
> > > +    emms_c();
> > 
> > this should be moved out of the inner loop of the codec
> Do you mean emms_c() should be moved out of this function?

if possible yes, but once a SSE* version exists this becomes unimportant


> You are not talking about the local variables I presume.  Well, I just copied that bit from ff_faandct().  Should that one be removed as well?

its not so easy to remove there so no


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110311/0a69806e/attachment.pgp>