[FFmpeg-devel] [PATCH] Add option to disable termios.h usage

[Takis Issaris]

Hi Nicolas,


----- Original Message ----
> From: Nicolas George <nicolas.george at normalesup.org>
> To: FFmpeg development discussions and patches <ffmpeg-devel at mplayerhq.hu>
> Cc: panagiotis at gmail.com
> Sent: Mon, March 7, 2011 1:33:36 PM
> Subject: Re: [FFmpeg-devel] [PATCH] Add option to disable termios.h usage
> 
> Le sextidi 16 vent?se, an CCXIX, Takis Issaris a ?crit :
> > The attached  patch adds an ffmpeg commandline option to allow one to disable 
>
> > ffmpeg  using tcgetattr and tcsetattr to modify terminal parameters.
> 
> ffmpeg ...  < /dev/null

Why would this work? tcsetattr is invoked regardless of where stdin comes from.

> 
> > In the end, the attributes do not get restored  correctly, forcing me to use 

> > "reset" or "stty sane".
> 
> A long time  ago I had sometime the problem with some programs. Then I added
> ttyctl -f in  my .zshrc and I never had to worry about that since  then.

Hmm, I do not really like that solution, if I understand correctly, it makes 
sure the
shell fixes the terminal settings after an application exits? It seems better to 
me
to not mess the terminal up in the first place, instead of relying on a specific 
shell's
feature to fix it.
 
Met vriendelijke groeten,
Takis