[FFmpeg-devel] [PATCH] add (e)ac3float decoders

[Justin Ruggles]

On 03/10/2011 10:11 AM, Ivan Kalvachev wrote:

> On 3/10/11, FB2000 <flybird2k at gmail.com> wrote:
>> On Tue, Mar 8, 2011 at 5:27 AM, Michael Niedermayer <michaelni at gmx.at>
>> wrote:
>>
>>> On Mon, Mar 07, 2011 at 03:01:46PM -0500, Justin Ruggles wrote:
>>>>
>>>> 1) There is no need for separate int16 and float decoders. The AC3
>>>> decoder is a floating-point decoder. It just happens to output int16 at
>>>> the end.
>>>
>>> can you send a patch that does this?
>>>
>>>
>> Well, if these are what wanted. See attached patches for AC3 and DCA.
> 
> These patches doesn't seem too intrusive.
> Is it possible to implement selectable output format through
> avctx->get_format() ?
> (or get_sample_format).
> 
> Leaving the integer format as default choice and listing the float one
> as second alternative.


Adding a request_sample_fmt field would be easy.  The user could set it
to request a sample format (which could optionally be ignored or used by
the selected decoder) or leave it as-is to get the default.  Once we
have planar audio support and an optimized conversion API, it will
become more practical to always output in the decoder's native sample
format and this option could be deprecated.

-Justin