[FFmpeg-devel] [PATCH] Bitmap Brothers JV demuxer

[Kostya]

On Thu, Mar 10, 2011 at 11:29:22PM +1100, Peter Ross wrote:
> ---
> On Wed, Mar 09, 2011 at 12:12:27PM +0100, Kostya wrote:
> > On Wed, Mar 09, 2011 at 09:45:41PM +1100, Peter Ross wrote:
> [..]
> > > > BTW, do you initialise state explicitly somewhere?
> > >
> > > JvContext.state defaults to zero when priv_data is allocated. In this updated
> > > patch, i've forced the JV_AUDIO state enum to be zero. That way theres no
> > > need to specifically initialise it in decode_init().
> >
> > I guessed that but for AVCodecs I think it's better to put that explicitly -
> > makes people wonder less from what state it starts.
> 
> Fixed.
> 
> > > +        case JV_PADDING:
> > > +            avio_skip(pb, FFMAX(e->size - jvf->audio_size - jvf->video_size - (jvf->palette ? 768 : 0), 0));
> >
> > ...but this one probably should be
> 
> And fixed.
 
Yep, now it looks fine to me.