[FFmpeg-devel] [PATCH 3/3] ac3enc: add SIMD-optimized shifting functions for use with the fixed-point AC3 encoder

Ronald S. Bultje rsbultje
Tue Mar 8 19:59:44 CET 2011


Hi,

On Tue, Mar 8, 2011 at 1:18 PM, Justin Ruggles <justin.ruggles at gmail.com> wrote:
> +%macro AC3_LSHIFT_INT16 1
> +cglobal ac3_lshift_int16_%1, 3,3,5, src, len, shift
> +    test   shiftd, shiftd
> +    jz .end
> +    movd       m0, shiftd
> +    ALIGN 8
> +.loop:
> +    AC3_SHIFT_4MM srcq, psllw, m0
> +    sub      lend, mmsize*2
> +    ja .loop

If it's not a multiple of mmsize*2, this will loop forever. Making
this jg (= signed) would fix that. Looks good otherwise.

Ronald



More information about the ffmpeg-devel mailing list