[FFmpeg-devel] [PATCH] avio: deprecate url_feof

[Ronald S. Bultje]

Hi,

On Mon, Mar 7, 2011 at 5:43 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Mar 07, 2011 at 05:34:10PM -0500, Ronald S. Bultje wrote:
>> Hi,
>>
>> On Mon, Mar 7, 2011 at 5:31 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Mon, Mar 07, 2011 at 05:29:14PM -0500, Ronald S. Bultje wrote:
>> >> On Mon, Mar 7, 2011 at 5:22 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >> > On Mon, Mar 07, 2011 at 09:50:25PM +0100, Anton Khirnov wrote:
>> >> >> AVIOContext.eof_reached should be used directly instead.
>> >> >
>> >> > If you are at eof, and some other process (wget?) appends to the file
>> >> > url_feof() could return 0 again. with direct access this is harder
>> >>
>> >> url_feof() reutrns s->eof_reached??
>> >
>> > you can put something else in there like
>> > if(protocol.check_eof()) return protocol.check_eof();
>>
>> Right, but that wasn't there for the past 5 years, so it's likely OK.
>
> the API hasnt changed in 5 years and so its ok to make it worse?
> nice reasoning

Ok, so do you want to make it a static av_always_inline avio_eof()
function then?

Ronald