[FFmpeg-devel] [PATCH 3/7] lavf: move ff_get_v from avio.h to avio_internal.h

[Michael Niedermayer]

On Mon, Mar 07, 2011 at 10:01:07PM +0000, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Mon, Mar 07, 2011 at 10:41:03AM -0500, Ronald S. Bultje wrote:
> >> Hi,
> >> 
> >> 2011/3/6 M?ns Rullg?rd <mans at mansr.com>:
> >> > "Ronald S. Bultje" <rsbultje at gmail.com> writes:
> >> >> On Sun, Mar 6, 2011 at 12:37 PM, Luca Barbato <lu_zero at gentoo.org> wrote:
> >> >>> On 03/06/2011 06:20 PM, M?ns Rullg?rd wrote:
> >> >>>> The function isn't public, so it shouldn't be in a public header, and
> >> >>>> the patch is OK in this regard. ?Making it public is another option on
> >> >>>> which I don't have much of an opinion.
> >> >>>
> >> >>> I'd make it public.
> >> >>
> >> >> It doesn't even have doxy. That function needs a lot of work before we
> >> >> can make it public.
> >> >
> >> > And a better name.
> >> 
> >> A better name it needs regardless.
> >
> > ff_nut_get_v()
> 
> What a stupid name.  There is nothing nut about it.  I've seen that
> encoding in lots of places.

its the encoding used in nut and what v referes too (see the nut spec)
either way, try to do some work on the code instead of trolling, id love
to pull some usefull changes from you instead of all the cosmetics.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110307/f766f454/attachment.pgp>