[FFmpeg-devel] [PATCH 2/2] replace all uses of url_fskip with avio_skip

[Måns Rullgård]

"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> Hi,
>
> On Thu, Mar 3, 2011 at 8:28 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>> Hi,
>>
>> On Thu, Mar 3, 2011 at 6:37 AM, Peter Ross <pross at xvid.org> wrote:
>>> This patch replaces all uses of url_fskip that existed prior to commit
>>> e356fc57a2e9887370caec58d8aafeafd1f336dc with the avio_skip macro.
>>
>> This suggests that it's not all of them. Anton's complaint about the
>> original code was that we were using 50% seek(SEEK_CUR) and 50% skip
>> for identical operations. We should either use one or the other, not a
>> combination of both.
>>
>> Is there some way that the remaining 50% can also be converted into skip?
>
> Ping, I will not apply this patch if we leave 50% of the code behind.
> That was the whole complaint of the old code also.

Well, there are cases where skip conveys the wrong notion.  Seeking
backwards for instance.

-- 
M?ns Rullg?rd
mans at mansr.com