[FFmpeg-devel] [PATCH 1/3] configure: improve pkg-config support

Måns Rullgård mans
Sun Mar 6 20:46:44 CET 2011


Reinhard Tartler <siretart at tauware.de> writes:

> On Sun, Mar 06, 2011 at 17:33:56 (CET), M?ns Rullg?rd wrote:
>
>> Reinhard Tartler <siretart at tauware.de> writes:
>>
>>> I understand your deep distrust in pkg-config, but additionally checking
>>> for missing headers here just checks for 'correctness' of pkg-config
>>> files. I think we can and should rely that existing .pc files are not
>>> broken and if we encouter broken ones, report them to upstreams and
>>> distros. This additional check feels like overdoing that to me.
>>>
>>> Or do I miss some important point here?
>>
>> I've seen pkg-config fail often enough not to trust it without an extra
>> check. 
>
> AFAIUI, this are bugs in .pc files, not pkg-config per se. .pc files are
> much easier to fix.

The bugs can be anywhere.  Sometimes they are easy to fix, sometimes not.

>> Common failure modes include reporting packages on the host
>> system rather a cross-target and requesting flags incompatible with
>> non-gcc compilers.  This check will catch both of those.  Otherwise
>> cross-builds will incorrectly report e.g. SDL as present and fail during
>> the build, the very situation Stefano sought to avoid.
>
> is sdl upstream that indifferent to not bother accepting a fix for their
> .pc files?

Evidently, and they're not the only ones.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list