[FFmpeg-devel] [PATCH 3/7] lavf: move ff_get_v from avio.h to avio_internal.h

Måns Rullgård mans
Sun Mar 6 18:49:11 CET 2011


"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> Hi,
>
> On Sun, Mar 6, 2011 at 12:37 PM, Luca Barbato <lu_zero at gentoo.org> wrote:
>> On 03/06/2011 06:20 PM, M?ns Rullg?rd wrote:
>>> The function isn't public, so it shouldn't be in a public header, and
>>> the patch is OK in this regard. ?Making it public is another option on
>>> which I don't have much of an opinion.
>>
>> I'd make it public.
>
> It doesn't even have doxy. That function needs a lot of work before we
> can make it public.

And a better name.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list