[FFmpeg-devel] [PATCH] configure: add check for pkg-config return value

[Måns Rullgård]

Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Sunday 2011-03-06 14:24:44 +0000, M?ns Rullg?rd encoded:
>> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>> 
>> > On date Sunday 2011-03-06 13:21:20 +0100, Diego Elio Petten? encoded:
>> >> Il giorno dom, 06/03/2011 alle 13.15 +0100, Stefano Sabatini ha scritto:
>> >> > 
>> >> > 
>> >> > > however temporary, to work around your broken system.
>> >> > 
>> >> > as I already told, this is a limitation of pkg-config, anyway here the
>> >> > problem is not philosophical but practical, this is an error which in
>> >> > practice will happen, preventing the error it's going to save
>> >> > headaches and bug-reports. 
>> >> 
>> >> Uhm Stefano, your system _is_ broken, you need libssl-dev installed.
>> >> That's a dependency of librtmp... the fact that you can get into such a
>> >> situation and come up "good" doesn't stop the fact that you lack a
>> >> package.
>> >
>> > My system is broken, but in a way which can be detected by pkg-config,
>> > having an additional check, even if unnecessary for the optimal case,
>> > makes the system more robust.
>> 
>> Please try out the patches I sent a few minutes ago.
>
> $ configure.my 
> Package libssl was not found in the pkg-config search path.
> Perhaps you should add the directory containing `libssl.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'libssl', required by 'librtmp', not found
> Package libssl was not found in the pkg-config search path.
> Perhaps you should add the directory containing `libssl.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'libssl', required by 'librtmp', not found
> ERROR: librtmp not found
>
> Works for me, so patch dropped, thanks.

Thanks for testing.

> Maybe we could avoid the repeated message, but this is a minor issue.

Those are because your broken system returns true for --exists and fails
in --cflags and --libs.

-- 
M?ns Rullg?rd
mans at mansr.com