[FFmpeg-devel] [PATCH 3/3] configure: check for --as-needed support early

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Sun, Mar 06, 2011 at 01:57:54PM +0000, Mans Rullgard wrote:
>> This moves the check for --as-needed linker support before all
>> library tests, ensuring consistent behaviour between the checks
>> and the actual link step.
>
> Can we move all linker flag tests before the library tests?
> I'd consider this cleaner and a quick test suggests it should
> be possible.

It's probably safe and a good idea, but I've learned to be cautious with
these things.  I'd rather not make any broad changes until we have a
stable Windows build back on FATE.

>> --- a/configure
>> +++ b/configure
>> @@ -2758,6 +2758,8 @@ if enabled asm; then
>>          $nogas "GNU assembler not found, install gas-preprocessor"
>>  fi
>>  
>> +check_ldflags -Wl,--as-needed
>
> A comment explaining why this linker check is before the others
> could be nice.

Nitpicking.

-- 
M?ns Rullg?rd
mans at mansr.com