[FFmpeg-devel] [PATCH] configure: add check for pkg-config return value

[Stefano Sabatini]

On date Sunday 2011-03-06 12:02:30 +0000, M?ns Rullg?rd encoded:
> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> 
> > On date Sunday 2011-03-06 00:02:21 +0000, M?ns Rullg?rd encoded:
> >> Diego Elio Petten? <flameeyes at gmail.com> writes:
> >> 
> >> > Il giorno dom, 06/03/2011 alle 00.02 +0100, Stefano Sabatini ha scritto:
> >> >> 
> >> >> Ping. 
> >> >
> >> > For what I'm concerned (and I have history with --as-needed), your
> >> > changes to configure to check for pkg-config return status are good.
> >> 
> >> Good in principle, not as good in implementation.  I've said I'll fix
> >> it, but I don't consider it high priority.
> >
> > So I suggest to apply this, which fixes the problem for me (TM), and
> > improve the implementation later.
> 
> No, I will not approve an ugly hack

Explain why adding a check on the return value of pkg-config is an
"ugly hack"

> however temporary, to work around your broken system.

as I already told, this is a limitation of pkg-config, anyway here the
problem is not philosophical but practical, this is an error which in
practice will happen, preventing the error it's going to save
headaches and bug-reports.
-- 
FFmpeg = Fabulous and Faithful Mournful Puristic Elfic Genius