[FFmpeg-devel] [PATCH] Add ppc/fmtconvert_ppc.c to fix compilation for PPC without Altivec.

[Reimar Döffinger]

Crap, could you please stop CCing me? I replied to the wrong address again.

On Sat, Mar 05, 2011 at 06:54:13AM -0500, Ronald S. Bultje wrote:
> On Sat, Mar 5, 2011 at 6:15 AM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de> wrote:
> >> + ? ?int mm_flags = av_get_cpu_flags();
> >> +
> >> + ? ?if (mm_flags & AV_CPU_FLAG_ALTIVEC && HAVE_ALTIVEC) {
> >
> > Is there any point to it? As far as I know as soon as
> > HAVE_ALTIVEC is set the code will crash on non-altivec
> > anyway so the av_get_cpu_flags is just confusing because
> > it pretends that something will work that does not at all.
> 
> On some systems (e.g. Darwin, I believe) it returns valid flags. On
> others it's a dummy.

Even if that were so, to my knowledge the code will still be
compiled with -maltivec and thus will still crash if altivec
is not available.