On Fri, Mar 04, 2011 at 03:25:15PM -0500, Justin Ruggles wrote: > - if (snr_offset < 0) > - return AVERROR(EINVAL); > + if (snr_offset < 0) { > + snr_offset = 0; > + if (bit_alloc(s, snr_offset) > bits_left) You just assigned it 0, so why use the variable instead of 0 directly?