[FFmpeg-devel] [rfc] merge the applehttp-urlprotocol into main

[Tomas Härdin]

Luca Barbato skrev 2011-03-04 11:40:
> On 02/28/2011 02:57 PM, Martin Storsj? wrote:
>> On Mon, 28 Feb 2011, Martin Storsj? wrote:
>>
>>> On Mon, 28 Feb 2011, Luca Barbato wrote:
>>>
>>>> On 02/28/2011 12:54 PM, Martin Storsj? wrote:
>>>>> That might indeed be a better route. Although I don't think we currently
>>>>> can handle registering a protocol that will catch any
>>>>> applehttp+<whatever>://, at the moment we'd have to register the full
>>>>> applehttp+<whatever>  as protocol name.
>>>>>
>>>>> What would be a good way of handling this? Adding a flag to URLProtocol,
>>>>> where a protocol can signal that it can work as a base protocol? That is,
>>>>> if this flag is set, we'd try to match only the part of the URL scheme up
>>>>> to the first + with this protocol name.
>>>>
>>>> might be useful go to this route and change the url splitter accordingly
>>>> in the long run.
>>>
>>> I'm not sure the url splitter in itself should be changed - there's no
>>> inherent meaning in using + as a separator. I'll try to prototype the
>>> thing I suggested above, though.
>>
>> Implemented this in the attached patches. Do you think this looks like a
>> sensible approach?
>
> I'd queue them up and push tomorrow, after that I might merge my
> protos[1] branch once cleaned up enough and switch rtsp to use the same
> format for it.
>
> Anybody against it? (I let a canonical week pass to hear more comments
> on it)

The only thing I can think of is that maybe make_absolute_url() can make 
use of some existing URI manipulation functions? Not sure thought. 
Otherwise LGTM.

Maybe later make_absolute_url() could be moved utils.c, once other code 
would fine it useful.

/Tomas