[FFmpeg-devel] [PATCH] Introduce avio_wtag.

[Måns Rullgård]

"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> Hi,
>
> On Thu, Mar 3, 2011 at 10:28 PM, Baptiste Coudurier
> <baptiste.coudurier at gmail.com> wrote:
>> ---
>> ?libavformat/avio.h ? ?| ? ?1 +
>> ?libavformat/aviobuf.c | ? ?9 +++++++--
>> ?2 files changed, 8 insertions(+), 2 deletions(-)
>
> <nag> It's unused. </nag>
>
> Now on a more serious note, I was OK with removing it because it's
> slow, unoptimized, duplicates functionality of existing functions in a
> poorly implemented way and so on.
>
> For the readability of 99% of the cases, we added ffio_wfourcc(). For
> the rest, avio_write() is sufficient because the string is always
> fixed-length. What is the (real, not theoretical) case where
> avio_wtag() does something that we don't already have in the
> before-mentioned functions?

It would be nice to get rid of the "foo", sizeof("foo") pairs, perhaps
with a macro.

> Besides, should probably be private, so ffio instead of avio prefix,
> and I doubt that "wtag" is a good function name, but then again as
> long as it's private that's not so much of an issue.

The word tag is used way too much.

-- 
M?ns Rullg?rd
mans at mansr.com