[FFmpeg-devel] [FFmpeg-commits] lavf: replace all uses of url_fskip with avio_seek

Måns Rullgård mans
Wed Mar 2 19:51:26 CET 2011


Luca Barbato <lu_zero at gentoo.org> writes:

> On 03/02/2011 07:13 PM, Reimar D?ffinger wrote:
>> Most of the code is essentially unchanged from a time when choosing the wrong
>> one would break things.
>> fskip will have been used for short seeks that would not cause issues with
>> non-seekable or badly seekable streams like stdin and http, fseek for
>> cases where you have given up on that.
>
> That should had been in doxy, was it?
>
>> As such the distinction served as a documentation at least.
>
> I guess it hadn't been much effective. =\

Regardless of intentions, the functions were exactly the same, skip()
simply calling seek(SEEK_CUR).  Having two ways of doing exactly the
same thing is always bad.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list