[FFmpeg-devel] [FFmpeg-commits] lavf: replace all uses of url_fskip with avio_seek

[Ronald S. Bultje]

Hi Peter,

On Wed, Mar 2, 2011 at 10:08 AM, Peter Ross <pross at xvid.org> wrote:
> On Tue, Mar 01, 2011 at 06:32:10PM +0100, Anton Khirnov ?wrote:
>> Module: ffmpeg
>> Branch: master
>> Commit: e356fc57a2e9887370caec58d8aafeafd1f336dc
>>
>> Author: ? ?Anton Khirnov <anton at khirnov.net>
>> Committer: Ronald S. Bultje <rsbultje at gmail.com>
>> Date: ? ? ?Mon Feb 28 14:57:55 2011 +0100
>>
>> lavf: replace all uses of url_fskip with avio_seek
>>
>> Signed-off-by: Ronald S. Bultje <rsbultje at gmail.com>
>>
>> ---
>
> [..]
>
>> ?libavformat/vocdec.c ? ? ? ? | ? ?8 +++---
>> ?libavformat/vqf.c ? ? ? ? ? ?| ? ?6 ++--
>> ?libavformat/wav.c ? ? ? ? ? ?| ? ?6 ++--
>> ?libavformat/wtv.c ? ? ? ? ? ?| ? 58 +++++++++++++++++++++---------------------
>
> Guys, the patch subject indicates what was done, but not why.
> Can somebody explain WHY the fskip convention has been replaced
> with seek. Im ignoring the original patch thread because that
> has gone political.

We have two functions that do the same thing: skip == seek(SEEK_CUR).
That is duplication and thus one was removed.

As said in the original patch, I agree a macro avio_skip or ffio_skip
defined to avio_seek(SEEK_CUR) is fine with me. I suggested it to
Anton and he preferred this patch over my suggestion. Since it's his
patch and nobody objected about it otherwise, I applied it. I'm still
fine with avio_skip as a macro defined to avio_seek(SEEK_CUR), but not
with two functions that do essentially the same thing.

Ronald