[FFmpeg-devel] [PATCH 2/3] lavf: replace all uses of url_fskip with avio_seek

Ronald S. Bultje rsbultje
Tue Mar 1 18:26:52 CET 2011


Hi,

2011/2/28 M?ns Rullg?rd <mans at mansr.com>:
> Anton Khirnov <anton at khirnov.net> writes:
>
>> @@ -304,7 +304,7 @@ static int flv_read_packet(AVFormatContext *s, AVPacket *pkt)
>> ? ? ?int64_t dts, pts = AV_NOPTS_VALUE;
>> ? ? ?AVStream *st = NULL;
>>
>> - for(;;url_fskip(s->pb, 4)){ /* pkt size is repeated at end. skip it */
>> + for(;;avio_seek(s->pb, 4, SEEK_CUR) < 0){ /* pkt size is repeated at end. skip it */
>> ? ? ?pos = url_ftell(s->pb);
>> ? ? ?type = avio_r8(s->pb);
>> ? ? ?size = avio_rb24(s->pb);
>
> Sorry, I misread that when skimming the grep output. ?That doesn't check
> the return value at all. ?Feel free to rewrite it in a sane way instead.

Queued without that "< 0" addition. Fixing that would be in a separate patch.

Ronald



More information about the ffmpeg-devel mailing list