[FFmpeg-devel] [PATCH] vsink_buffer: don't abort in case of missing frame

Stefano Sabatini stefano.sabatini-lala at poste.it
Tue Jun 28 10:57:50 CEST 2011

On date Tuesday 2011-06-28 04:41:42 +0200, Michael Niedermayer encoded:
> On Mon, Jun 27, 2011 at 11:49:22PM +0200, Stefano Sabatini wrote:
> > Do not return AVERROR(EINVAL) in
> > av_vsink_buffer_get_video_buffer_ref() if no frame is immediately
> > returned, but keep requesting frames.
> > 
> > This is required for filters which cache frames, e.g. the tinterlace
> > filter, for which a frame is not immediately returned at the first
> > avfilter_request_frame() call.
> This feels like a bug in tinterlace to me.
> it could call request twice if it needs that to output a frame
> I think its easier if request_frame() must output a frame or fail with
> error.
> otherwise i think every use of that function would need to be in a
> loop and there might even be an issue with it doing infinite loops if
> it never returns a frame but doesnt error out either

Fixed tinterlace instead, patch drawn back.
FFmpeg = Foolish and Frenzy Mythic Porno Explosive Governor

More information about the ffmpeg-devel mailing list