[FFmpeg-devel] [PATCH] libavcodec/libx264.c: distinguish between x264 parameter errors

[Erik Slagter]

> The main issue is about the coding style. Some precisions attached.

[ .. ]

> Please break this line (80 columns):

Done, and some other too. Quite a few lines > 80 coumns remain in this file
though.

>> +{
>> +    if(!param)
>
> The coding style prefers "if (", even if most the style is non consistent
> in that file.

Imho that's even an understatement. Done.

>> +        return(1);
> return 1;

All of them done.

> switch (...) {

Done.

>> +        case(X264_PARAM_BAD_NAME): { av_log(avctx, AV_LOG_ERROR, "no such option: \"%s\"\n", opt); return(0); }

> Pointless { }, 80 columns prefered.

All done.

New patch follows when I have read and processed Etienne Buira's comments as well.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5110 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110624/5823a8b7/attachment.p7s>