[FFmpeg-devel] [PATCH] libavcodec/libx264.c: distinguish between x264 parameter errors

Erik Slagter erik at slagter.name
Fri Jun 24 11:16:54 CEST 2011

ES>> I don't understand what you're trying to say here. The function you're
ES>> describing here is functionally equivalent to my version.

EB> No, the one I describe doesn't (almost) invert x264_param_parse return
EB> value.

Objection: It will print a warning even when the parameter is
correct (ret == 0). That could be overcome by adding another case
statement. Personally I don't like it this way because the caller
of opt_str shouldn't have any knowledge of what (library) functions
opt_str calls and so it should get a simple "ok" or "not ok" and not
the return value of a call to some other function, that might be
replaced at any time.

I understand this is mostly personal taste (differing from what's
"common" here) but I really think this particular issue is really
too trivial to fight about. Now if it were in a time-critical
code path, but it clearly isn't.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5110 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110624/b814cc18/attachment.p7s>

More information about the ffmpeg-devel mailing list