[FFmpeg-devel] [PATCH] OpenAL 1.1 Capture Support

[Jonathan Baldwin]

>> Sorry for the delay, I was kind of busy.
++;

> Please verify that this is correctly rendered in the man page (the
> last time I checked, multi-tables are not correctly displayed), in
> this case the previous approach would be just fine.

Apparently upstream texi2pod.pl (gcc) does, but the output doesn't
look to pleasant IMHO anyways. Wasted a few hours messing with it, and
decided it was easier to avoid multi-tables. Changed to a plain old
two-column @table.

> Note: it would be useful to list the available supported devices,
> e.g. with a list option which returns AVERROR_EXIT (no need to do it
> in this patch though).

Regarding the list option,

Can something like
$ ffmpeg -f openal -list_devices
be achieved, or is
$ ffmpeg -f openal -list_devices 1
or even
$ ffmpeg -f openal -list_devices 1 ''
the best I can get?

I found AV_OPT_TYPE_FLAGS, is this relevant, and how would I use it?

>
> SAMPLES_SIZE?
>

No longer needed anymore.

>
> just curious, from where this magic number comes from?
>

I needed an appropriate size for my buffer. Turns out this wasn't so
appropriate - it was a bit inflated. Now it isn't needed anymore
because the buffer was replaced with as neccesary packet allocation
via av_new_packet, as suggested.

>
> Nit: sample_step looks more explicative (number of bytes between two
> consecutives samples of the same channel/component).
>

Done.

>
> Nit+++: nb_samples -> more consistent with the rest of FFmpeg
>

Done.

>
> I believe here you need to put the data directly into the packet.
>
> You may get nb_samples, create a new packet with av_new_packet(),
> and finally fill it with alcCaptureSamples().
>

Done. Static buffer[] removed, samples go into the packet allocated by
av_new_packet().
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ff_oal_patch_revised_3.diff
Type: text/x-patch
Size: 14946 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110617/0275c18d/attachment.bin>