[FFmpeg-devel] Full support for sending H.264 in RTP

[Luca Abeni]

Hi Michael,

On 06/15/2011 06:13 PM, Michael Niedermayer wrote:
[...]
>> I know this patch causes some code duplication (or quadruplication :);
>> this is why I never submitted it for inclusion (it is actually a quite
>> old patch).
>> But I continuously receive private emails from people asking for the
>> patch... So, at least now it is archived in the mailing list
>> archives ;-)
>
> patch applied, if so many people want it we should include it.
Thanks. This will hopefully decrease the number of "RTP in ffmpeg is broken"
kind of emails I receive ;-)

[...]
> also thx for the patch and welcome back!
> and please send me your public ssh key so i can give you git write
> access.
Well, I am not really back yet... I am still busy with some personal
issues, and I am still a bit worried about the "ffmpeg vs libav" thing.
Anyway, if things work well, I'll be back: I'll re-subscribe to ffmpeg-devel,
and I'll send the public key.


For the moment, I just investigated the crash I mentioned in my previous
email:
- it happens only in the "oldabi" branch
- it is caused by
	av_log( h, AV_LOG_INFO, "circular_buffer_info max:%d%%\r\n", (s->circular_buffer_available_max*100)/s->circular_buffer_size);
   in udp.c:udp_close() (I guess a URLContext cannot be used in av_log(),
   because it does not contain an AVClass?)
- it is fixed in master by commit 8146d16b60ec84aae93cfc4a9444d879f9d5bbfc
   which removes the av_log()

So, I guess the crash will disappear next time that oldabi is updated (or
if 8146d16b60ec84aae93cfc4a9444d879f9d5bbfc is cherry-picked).



				Luca