[FFmpeg-devel] [PATCH] avfiltergraph: make the AVFilterInOut alloc/free API public

Michael Niedermayer michaelni at gmx.at
Sun Jun 12 17:06:34 CEST 2011


On Sun, Jun 12, 2011 at 11:31:04AM +0200, Stefano Sabatini wrote:
> On date Saturday 2011-06-11 19:58:14 +0200, Michael Niedermayer encoded:
> > On Sat, Jun 11, 2011 at 04:12:31PM +0200, Stefano Sabatini wrote:
> > > Required for letting applications to create and destroy such structs
> > > in a convenient way.
> > [...]
> > > +void avfilter_inout_free(AVFilterInOut **inout)
> > > +{
> > > +    while (*inout) {
> > > +        AVFilterInOut *next = (*inout)->next;
> > > +        av_free((*inout)->name);
> > > +        av_free(*inout);
> > 
> > i think av_freep() is safer
> 
> Indifferent to me, I used av_free because the variable are local and
> the syntax was simpler with av_free().

->name isnt local
new patch LGTM

and thx for taking care of my av_freep() nitpick

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110612/f26a0843/attachment.asc>


More information about the ffmpeg-devel mailing list