[FFmpeg-devel] [PATCH] Per-frame metadata

Nicolas George nicolas.george at normalesup.org
Fri Jun 10 20:47:51 CEST 2011


Hi. After the recent move of the metadata API to libavutil, I rebased and
reworked my proposal for per-frame metadata decoding:

1/5: Introduce av_size_mult and av_realloc_f

This is very similar to the original proposal. The chunk with av_size_mult
was ok-ed, but was later changed to return an AVERROR code rather than -1.

I also learned in the meantime that BSD has a reallocf function, which is
similar to the proposed av_realloc_f: it frees the memory if it fails, but
it does not check for integer overflow.

2/5: Replace av_realloc by av_realloc_f when relevant

Unchanged except for merge conflicts.

3/5: Introduce a metadata field in AVFrame

It also introduces CODEC_FLAG2_FRAME_METADATA: per-frame metadata is only
decoded if this flag is set. This avoids memory leaks if release_buffer does
not free the metadata.

4/5: PNG: decode textual data (tEXt and zTXt chunks)

Almost identical to the original proposal.

5/5: ffmpeg: dump per-frame metadata

For testing purposes; I am not sure if we want it or not.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Introduce-av_size_mult-and-av_realloc_f.patch
Type: text/x-diff
Size: 2810 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110610/905de545/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Replace-av_realloc-by-av_realloc_f-when-relevant.patch
Type: text/x-diff
Size: 26171 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110610/905de545/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Introduce-a-metadata-field-in-AVFrame.patch
Type: text/x-diff
Size: 3218 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110610/905de545/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-PNG-decode-textual-data-tEXt-and-zTXt-chunks.patch
Type: text/x-diff
Size: 10445 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110610/905de545/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-ffmpeg-dump-per-frame-metadata.patch
Type: text/x-diff
Size: 1684 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110610/905de545/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110610/905de545/attachment.asc>


More information about the ffmpeg-devel mailing list