[FFmpeg-devel] [CRASH]

[Michael Niedermayer]

On Tue, Jun 07, 2011 at 11:46:31PM +0200, Etienne Buira wrote:
> On Tue, Jun 07, 2011 at 11:25:19PM +0200, Stefano Sabatini wrote:
> > On date Tuesday 2011-06-07 23:08:29 +0200, Etienne Buira encoded:
> > > diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c
> > > index cf0eb43..8be0192 100644
> > > --- a/libavfilter/vf_drawtext.c
> > > +++ b/libavfilter/vf_drawtext.c
> > > @@ -349,13 +349,6 @@ static av_cold void uninit(AVFilterContext *ctx)
> > >      DrawTextContext *dtext = ctx->priv;
> > >      int i;
> > >  
> > > -    av_freep(&dtext->fontfile);
> > > -    av_freep(&dtext->text);
> > > -    av_freep(&dtext->expanded_text);
> > > -    av_freep(&dtext->fontcolor_string);
> > > -    av_freep(&dtext->boxcolor_string);
> > > -    av_freep(&dtext->positions);
> > > -    av_freep(&dtext->shadowcolor_string);
> > >      av_tree_enumerate(dtext->glyphs, NULL, NULL, glyph_enu_free);
> > >      av_tree_destroy(dtext->glyphs);
> > >      dtext->glyphs = 0;
> > 
> > Uh, why this? As far as I know av_opt_free() is not (yet?) used in
> > libavfilter.
> 
> Sorry, didn't check actually, I assumed it was used whenever AVOption
> were used.
> 
> Attached the only (corrected) interesting part.
> 

>  crypto.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> f9e64fcd88dc6fd43318ae623d379e22173ccfaf  ffmpeg_av_opt_free_crypto.diff
> diff --git a/libavformat/crypto.c b/libavformat/crypto.c

commited

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110608/d44396bb/attachment.asc>