[FFmpeg-devel] [PATCH] pixcolorinfo: remove unused PixFmtInfo.depth field

[Michael Niedermayer]

On Mon, Jul 25, 2011 at 10:58:31AM +0200, Stefano Sabatini wrote:
> On date Monday 2011-07-25 02:14:53 +0200, Michael Niedermayer encoded:
> > On Sun, Jul 24, 2011 at 03:49:41PM +0200, Stefano Sabatini wrote:
> > > Use information stored in pixdesc instead.
> > > ---
> > >  libavutil/pixcolorinfo.c |   54 ----------------------------------------------
> > >  libavutil/pixcolorinfo.h |    1 -
> > >  2 files changed, 0 insertions(+), 55 deletions(-)
> > 
> > we cannot do this if this is moved to libavutil and used from outside
> > it would break ABI and would need major bumps, thats
> > also why i think the move of this to lavu is not a good idea
> 
> The table was static, so was only used in imgconvert.o.
> 
> The move adds a dependency of the kind
> lavc 53.A.B requires lavu >= 51.X.Y
> 
> I'll bump both lavu and lavc micro when moving the table, as done
> previously in other cases (e.g. when using internally a new function
> defined in lavu).
> 
> But I see that it is better to remove the field *before* to do the
> move.

The problem is that if its made public (which the move would do)
then nothing can be added or removed anymore
i thus think the move is not a good idea

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110725/95860e3a/attachment.asc>