[FFmpeg-devel] [PATCH] h264 - correct the check for invalid long term frame index in MMCO decode

Michael Niedermayer michaelni at gmx.at
Wed Jul 20 10:17:26 CEST 2011

On Mon, Jul 18, 2011 at 01:45:42PM -0400, Jeff Downs wrote:
> On Mon, 18 Jul 2011, Michael Niedermayer wrote:
> > On Tue, Jul 05, 2011 at 02:36:06PM -0400, Jeff Downs wrote:
> > > The current checks on MMCO parameters prohibits a "max long term frame index
> > > plus 1" of 16 (frame idx of 15) for the "set max long term frame index" MMCO.
> > > Fix this off-by-one error to allow the full range of legal values.
> > 
> > do you have a testcase / bitstream sample for this ?
> Yes, I do, but it is part of a licensed compliance/test set and sadly 
> cannot share it.
> I did verify it against the spec - the current check is not handling the 
> boundary condition properly.
> I don't know if you'd ever see an actual stream like this, but it was an 
> easy enough fix.

thanks for the info & thanks for the bugfix
patch ok

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110720/0a16f477/attachment.asc>

More information about the ffmpeg-devel mailing list