[FFmpeg-devel] swscale dither

Thomas Worth dev at rarevision.com
Fri Jul 15 18:44:11 CEST 2011


On Fri, Jul 15, 2011 at 9:11 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Jul 15, 2011 at 08:42:03AM -0700, Thomas Worth wrote:
>> > Also you still use 32bit buffers all over the place for handling 10bit
>> > data. ffmpegs code uses 32bit buffers only when needed to maintain
>> > precission and 16bit otherwise. Which should make ffmpegs swscale
>> > twice as fast on 10bit data once its all done with SIMD :)
>> > I dont mind at all if it stays that way :))))
>> > nor do i if you reimplement or take my code as its then less work for
>> > me to maintain the 16/32bit buffer feature :)))))
>>
>> Wouldn't 32 bit be faster since you can pack a single 10 bit R,G,B
>> pixel into 32 bits with padding?
>
> thats not what ronalds code does.
> ronald puts one 10bit sample in 32bit wasting 22bits and half cpu time

Right, yes that is a waste.


> and its yuv not rgb (though that makes no difference to the argument)

Oh right, v210, sure. Although r210 and r10k should be supported for
encoding, too. I see they are supported for decoding. Sort of like
PIX_FMT_YUV422P10LE but for RGB instead of YUV. Should be pretty
simple to implement, since it's uncompressed data
(PIX_FMT_RGB44410LE?).


More information about the ffmpeg-devel mailing list